Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to pom following 0e701b271e04e60c6fa89f39299dae7142d700b8 #328

Merged
merged 1 commit into from Jul 23, 2019
+5 −10

Conversation

Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @codecov-io @ianmilligan1
@ruebot
Copy link
Member

commented Jul 23, 2019

What does this Pull Request do?

  • Remove explicit Guava dependency (should have been remove in
    0e701b2)
  • Update Scala to 2.11.12; aligns with Spark 2.4.3
  • Update Scala test
  • Update Shapeless
  • Update Scala lang parsers
  • Fix a typo in a test

The updates are mostly to get aut back to a place where we don't have mixed Scala version warnings. However, as I dug deeper into getting everything up to 2.11.12 we ran into lots of problems. This gets us part of the way there, and we can come back later should we want to.

How should this be tested?

  • TravisCI
  • I tested locally with a language extraction and full text text extraction scripts.
@ruebot
Updates to pom following 0e701b2 
- Remove explicit Guava dependency (should have been remove in
0e701b2)
- Update Scala to 2.11.12; aligns with Spark 2.4.3
- Update Scala test
- Update Shapeless
- Update Scala lang parsers
- Fix a typo in a test
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
9488280

@ruebot ruebot requested a review from ianmilligan1 Jul 23, 2019

@ianmilligan1

ianmilligan1 approved these changes Jul 23, 2019
View changes

Copy link
Member

left a comment

Tested locally and all checks out. Once TravisCI turns green I'll merge!
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Jul 23, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files          39       39           
  Lines        1123     1123           
  Branches      197      197           
=======================================
  Hits          842      842           
  Misses        215      215           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5ef14...9488280. Read the comment docs.

@ianmilligan1 ianmilligan1 merged commit 19b49e1 into master Jul 23, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing bd5ef14...9488280
Details
codecov/project 74.97% remains the same compared to bd5ef14
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the more-clean-up branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.