New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.63.0 #59

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@depfu
Copy link
Contributor

depfu bot commented Jan 17, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.62.0 → ~> 0.63.0) · Repo · Changelog

Release Notes

0.63.0

New features

Bug fixes

  • #6627: Fix handling of hashes in trailing comma. (@abrom)
  • #6623: Fix heredoc detection in trailing comma. (@palkan)
  • #6100: Fix a false positive in Naming/ConstantName cop when rhs is a conditional expression. (@tatsuyafw)
  • #6526: Fix a wrong line highlight in Lint/ShadowedException cop. (@tatsuyafw)
  • #6617: Prevent traversal error on infinite ranges. (@drenmi)
  • #6625: Revert the "auto-exclusion of files ignored by git" feature. (@bbatsov)
  • #4460: Fix the determination of unsafe auto-correct in Style/TernaryParentheses. (@jonas054)
  • #6651: Fix auto-correct issue in Style/RegexpLiteral cop when there is string interpolation. (@roooodcastro)
  • #6670: Fix a false positive for Style/SafeNavigation when a method call safeguarded with a negative check for the object. (@koic)
  • #6633: Fix Lint/SafeNavigation complaining about use of to_d. (@tejasbubane)
  • #6575: Fix Naming/PredicateName suggesting invalid rename. (@tejasbubane)
  • #6673: Fix Style/DocumentationMethod cop to recognize documentation comments for def inline with module_function. (@tejasbubane)

Changes

  • #6607: Improve CLI usage message for --stdin option. (@jaredbeck)
  • #6641: Specify Performance/RangeInclude as unsafe because Range#include? and Range#cover? are not equivalent. (@koic)
  • #6636: Move FlipFlop cop from Style to Lint department because flip-flop is deprecated since Ruby 2.6.0. (@koic)
  • #6661: Abandon making frozen string literals default for Ruby 3.0. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 45 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 17, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #59   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e20a6...f58d4c9. Read the comment docs.

@ruebot

ruebot approved these changes Jan 17, 2019

@ruebot ruebot merged commit b43c0d9 into master Jan 17, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 96e20a6...f58d4c9
Details
codecov/project 100% remains the same compared to 96e20a6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-0.63.0 branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment