Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.rst #856

Merged
merged 6 commits into from Oct 23, 2019
Merged

Update CONTRIBUTING.rst #856

merged 6 commits into from Oct 23, 2019

Conversation

@fehrhart
Copy link
Collaborator

fehrhart commented Oct 15, 2019

Adding an example how to add a new sparql query to scholia

Adding an example how to add a new sparql query to scholia
1. Assign the task for yourself (if it is in an issue tracker)
2. Get the new query e.g.
E.g.
SELECT DISTINCT ?author ?authorLabel ?award ?awardLabel WHERE {

This comment has been minimized.

Copy link
@fnielsen

fnielsen Oct 15, 2019

Owner

There is a bit of a formatting issue with the code. Perhaps some indentation is needed?

This comment has been minimized.

Copy link
@fehrhart

fehrhart Oct 15, 2019

Author Collaborator

looks not as intended... ill check!

fehrhart added 3 commits Oct 15, 2019
@fehrhart

This comment has been minimized.

Copy link
Collaborator Author

fehrhart commented Oct 15, 2019

I think I got it now...
Someone please check if code:: python is correct for line 91!
Please give the correct file name for line 89

e.g. authorAwardsSparql
3. Add a name (within your own fork of the file https://github.com/fnielsen/scholia/tree/master/scholia[…]) e.g. authorAwardsSparql

.. code:: python

This comment has been minimized.

Copy link
@fnielsen

fnielsen Oct 15, 2019

Owner

This should be Javascript

This comment has been minimized.

Copy link
@fehrhart

fehrhart Oct 23, 2019

Author Collaborator

done

@@ -97,10 +100,14 @@ e.g. authorAwardsSparql
4. Add that name to the sparql-to-data table

.. code:: python

This comment has been minimized.

Copy link
@fnielsen

fnielsen Oct 15, 2019

Owner

This is also Javascript

This comment has been minimized.

Copy link
@fehrhart

fehrhart Oct 23, 2019

Author Collaborator

done

sparqlToDataTable(authorAwardsSparql, "#author-awards");
5. Add some table formatting

.. code:: html

<h2 id="AuthorAwards">Author Awards</h2>

This comment has been minimized.

Copy link
@fnielsen

fnielsen Oct 15, 2019

Owner

I think <h2 id="Author-awards">Author awards</h2> would be better, i.e., lower case section words, except the first. A make a dash in the id for the space.

This comment has been minimized.

Copy link
@fehrhart

fehrhart Oct 23, 2019

Author Collaborator

done

e.g. authorAwardsSparql
3. Add a name (within your own fork of the file https://github.com/fnielsen/scholia/tree/master/scholia[…]) e.g. authorAwardsSparql

.. code:: python
authorAwardsSparql =

This comment has been minimized.

Copy link
@fnielsen

fnielsen Oct 15, 2019

Owner

There is a backtick missing

This comment has been minimized.

Copy link
@fehrhart

fehrhart Oct 23, 2019

Author Collaborator

done

fehrhart added 2 commits Oct 23, 2019
@fnielsen

This comment has been minimized.

Copy link
Owner

fnielsen commented Oct 23, 2019

Here are a few issues you might consider

  1. Fix identation in SPARQL code (SERVICE lines and "wdt:P50 ?author ." for instance)
  2. Change "Author Awards" to "Author awards"
  3. Add a "`"'s to the Javascription code.
fnielsen added a commit that referenced this pull request Oct 23, 2019
@fnielsen fnielsen merged commit 037224f into fnielsen:master Oct 23, 2019
1 check passed
1 check passed
security/snyk - requirements.txt (fnielsen) No manifest changes detected
@fnielsen

This comment has been minimized.

Copy link
Owner

fnielsen commented Oct 23, 2019

I have just done the issues. I hope they are ok?

@fehrhart

This comment has been minimized.

Copy link
Collaborator Author

fehrhart commented Oct 24, 2019

sure, thanks!

@fehrhart fehrhart deleted the fehrhart:patch-1 branch Oct 24, 2019
AlexanderPico added a commit to wikipathways/scholia that referenced this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.