Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSeparate into 3 Notebooks - Issue 46 #51
Conversation
greebie
added some commits
Apr 11, 2019
ianmilligan1
requested changes
Apr 11, 2019
As requested, providing some initial feedback on the domains notebook. In-line mark-up is a bit ungainly for the changes I'm requested, so I will just provide them here. This is looking good! On a fresh pull and kernel, the I basically think we need to customize the opening section of the notebooks so that they're all bit different.
Otherwise, I think the domains notebook is almost ready to go. Looking forward to reviewing the next ones (ping me in Slack or here when you want me to do a once over), although I think the feedback here is generalizable across the domains, text, and network ones. |
ruebot
referenced this pull request
Apr 11, 2019
Merged
Setup notebook to run with au_notebook as a library; resolves #50 #52
greebie
added some commits
Apr 15, 2019
greebie
marked this pull request as ready for review
Apr 15, 2019
This comment has been minimized.
This comment has been minimized.
I pulled this out of draft mode for review. I kept the current larger notebook inside the repo and will remove it as the last commit upon completion of the review requests. |
greebie
requested a review
from
ianmilligan1
Apr 15, 2019
ianmilligan1
requested changes
Apr 16, 2019
This comment has been minimized.
This comment has been minimized.
Please be consistent on "notebook" capitalization. It's different in each of the notebook files. |
ianmilligan1
requested changes
Apr 16, 2019
Few minor stylistic changes and then its good to go on my end, thx @greebie |
"\n", | ||
"# Welcome to the Domains Analysis Notebook\n", | ||
"\n", | ||
"Welcome to the Archives Unleashed domains analysis Jupyter Notebook. This demonstration takes the domain derivatives from the Cloud and uses Python to analyze and produce information about your collection.\n", |
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Apr 16, 2019
Member
Let's capitalize Domains Analysis in Welcome to the Archives Unleashed domains analysis Jupyter Notebook.
i.e. so that it reads Welcome to the Archives Unleashed Domains Analysis Jupyter Notebook.
"\n", | ||
"Welcome to the Archives Unleashed domains analysis Jupyter Notebook. This demonstration takes the domain derivatives from the Cloud and uses Python to analyze and produce information about your collection.\n", | ||
"\n", | ||
"Please feel free to create an [issue](https://github.com/archivesunleashed/auk/issues) to let us know about any bugs you encountered or improvements you would like to see.\n", |
This comment has been minimized.
This comment has been minimized.
"\n", | ||
"# Welcome to the Text Analysis Notebook\n", | ||
"\n", | ||
"Welcome to the Archives Unleashed text analysis Jupyter Notebook. This demonstration takes the full text derivatives from the Cloud and uses Python to analyze the derivatives for your collection.\n", |
This comment has been minimized.
This comment has been minimized.
"\n", | ||
"Welcome to the Archives Unleashed text analysis Jupyter Notebook. This demonstration takes the full text derivatives from the Cloud and uses Python to analyze the derivatives for your collection.\n", | ||
"\n", | ||
"Please feel free to create an [issue](https://github.com/archivesunleashed/auk/issues) to let us know about any bugs you encountered or improvements you would like to see.\n", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@greebie remove |
greebie commentedApr 11, 2019
The title says it all.
This adds a domain, text and network notebook instead of the previous "all-in-one" approach.
I added some additional analysis to domains because it was too short.
This will be in draft until all the edits are done. Final commit will remove the larger notebook.