Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Docker for notebooks #8

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ruebot
Copy link
Member

ruebot commented Mar 1, 2019

  • Add Dockerfile,
  • Add required nltk data
  • Add instructions in README

Test:

screenshot from 2019-03-01 15-26-36

screenshot from 2019-03-01 15-26-53

screenshot from 2019-03-01 15-27-06

screenshot from 2019-03-01 15-27-21

screenshot from 2019-03-01 15-27-38

screenshot from 2019-03-01 15-27-57

screenshot from 2019-03-01 15-28-11

screenshot from 2019-03-01 15-28-23

@ruebot ruebot force-pushed the docker branch from f68ae87 to 79b9455 Mar 1, 2019

@ruebot ruebot requested review from ianmilligan1 , greebie and SamFritz Mar 1, 2019

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 1, 2019

I haven't added this into the README yet, but if you want to include your own data or notebooks:

Just data:

  • docker run --rm -it -p 8888:8888 -v "/path/to/own/data:/home/jovyan/data" auk-notebook

Just notebook(s)

  • docker run --rm -it -p 8888:8888 -v "/path/to/own/notebookst:/home/jovyan" auk-notebook

Both:

  • docker run --rm -it -p 8888:8888 -v "/path/to/own/notebookst:/home/jovyan" -v "/path/to/own/data:/home/jovyan/data" auk-notebook

Figured we can wait on incorporating this. I'd like us to consider removing one of the two notebooks we have now. Then replace it with a notebook that has the data variables blank (maybe this is the middle step to the auk version?). We can discuss this more on the next call if that makes things easier, or I can create an issue, and start working on it.

@ianmilligan1

This comment has been minimized.

Copy link
Member

ianmilligan1 commented Mar 2, 2019

Great, thanks @ruebot – this looks awesome (I got to see a sneak peak of it in real life over Nick's shoulder this afternoon).

I will probably test this on Monday (or this weekend if I can find a moment, but probably Monday). I think a notebook that has the data variables blank makes sense to me, but curious to hear @greebie's thoughts as the repo's original architect.

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 2, 2019

I agree with removing the second notebook. The only reason it was there in the first place was to show the community what it looked like without having to clone and run Jupyter. It has no other purpose.

I also agree the next step is to include some kind of markup for the things we want variable in auk. Collection is obvious, but I also things like the data folder, descriptive information (title, organization, etc. if possible) and maybe even consider a partner logo.

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 2, 2019

Only question in my mind is whether to remove ggplot from the dep list. I saw you added the hack, so I'm fine with keeping it. The only advantage is that the ggplot graphs etc. are more pretty than matplotlib. None of the scripts use ggplot as it stands.

Setup Docker for notebooks
- Add Dockerfile,
- Add required nltk data
- Add instructions in README

@ruebot ruebot force-pushed the docker branch from 79b9455 to a8626fb Mar 2, 2019

@ruebot ruebot referenced this pull request Mar 2, 2019

Open

Generic notebook #9

@ianmilligan1

This comment has been minimized.

Copy link
Member

ianmilligan1 commented Mar 2, 2019

Let’s keep things as simple as we can, in case our WASAPI partners ever increase. I’d be inclined to avoid things like partner logos, etc. and just keep to collection ID and perhaps collection title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.