Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case-insensitive Bag-Info tags (Issue #21) #22

Merged
merged 4 commits into from Mar 24, 2020

Conversation

@tdilauro
Copy link
Member

tdilauro commented Mar 23, 2020

Fixes/implements #21 (case-insensitive Bag-Info tags).

  • Adds ignore_baginfo_tag_case property to Profile class;
  • Adds -i and --ignore_baginfo_tag_case flags used to set the associated Profile property;
  • Appends help text to some error messages to indicate that an "ignore case" option is available;
  • Adds new tests.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #22 into master will increase coverage by 1.88%.
The diff coverage is 91.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   80.73%   82.61%   +1.88%     
==========================================
  Files           2        2              
  Lines         436      489      +53     
==========================================
+ Hits          352      404      +52     
- Misses         84       85       +1     
Impacted Files Coverage Δ
bagit_profile.py 71.02% <80.95%> (+1.28%) ⬆️
test.py 98.54% <97.56%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e7eec...7dd3547. Read the comment docs.

@tdilauro tdilauro requested a review from ruebot Mar 23, 2020
@ruebot
ruebot approved these changes Mar 24, 2020
Copy link
Member

ruebot left a comment

Thanks so much @tdilauro!

@ruebot ruebot merged commit e73b662 into bagit-profiles:master Mar 24, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch 91.93% of diff hit (target 80.73%)
Details
codecov/project 82.61% (+1.88%) compared to 41e7eec
Details
@tdilauro

This comment has been minimized.

Copy link
Member Author

tdilauro commented Mar 24, 2020

No problem.

@tdilauro tdilauro deleted the tdilauro:feat-ignore_baginfo_tag_case branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.