Skip to content

/ usrse.github.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small grammar fix in US-RSE Association goals page #182

Merged
merged 6 commits into from Mar 26, 2020
Merged

small grammar fix in US-RSE Association goals page #182

merged 6 commits into from Mar 26, 2020
+3 −11

Conversation

@danielskatz
Copy link
Collaborator

danielskatz commented Mar 26, 2020 •
edited

Description

adding apostrophe to fix grammar

Motivation and Context

fixes grammar

Checklist:

  • I have posted the link for the PR in the usrse slack (#website) to ask for reviewers
  • I have previewed changes locally
  • I have updated the CHANGELOG and (if necessary) the README.md

minor change - update of CHANGELOG not required.

cc @usrse-maintainers
@danielskatz
small grammar fix
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
238fbb9
@vsoch

This comment has been minimized.

Sign in to view
Copy link
Member

vsoch commented Mar 26, 2020

Looks like the same typo is here too: https://us-rse.org/mission/
@vsoch

This comment has been minimized.

Sign in to view
Copy link
Member

vsoch commented Mar 26, 2020

For the urlchecker looks like the Princeton links have expired and should be removed. See red in https://github.com/USRSE/usrse.github.io/pull/182/checks?check_run_id=536630945.
@danielskatz
fixing gramma
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e72ce2
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

danielskatz commented Mar 26, 2020

thanks - I've now fixed the other instance in mission as well
danielskatz added 3 commits Mar 26, 2020
@danielskatz
removing old Princeton job with broken link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
513a0ab 
trial and error...
@danielskatz
removing 2nd princeton job with broken link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a0db4cb
@danielskatz
adding newsletter to URLs not to check
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
61826c5 
old newsletters will, over time, have URLs that no longer work, but I think it's better to leave them than to edit the content of archived newsletters.
@vsoch
vsoch reviewed Mar 26, 2020
View changes
.github/workflows/urlchecker.yml
@@ -21,7 +21,7 @@ jobs:
retry_count: 3

# White listed patterns (seem to have SSL issues but work in browser)
white_listed_patterns: sc19.supercomputing.org,https://pace.gatech.edu
white_listed_patterns: sc19.supercomputing.org,https://pace.gatech.edu,github/workspace/_posts/newsletters/

This comment has been minimized.

Sign in to view
Copy link
@vsoch

vsoch Mar 26, 2020

Member

@danielskatz you added to the wrong line (not the one that I linked) this is white_listed_patterns (for urls) and I linked you to the last one, white_listed_files.

This comment has been minimized.

Sign in to view
Copy link
@danielskatz

danielskatz Mar 26, 2020

Author Collaborator

ok, thanks - will fix
@danielskatz
fixing don't check newsletter URLs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
28bd65b 
hopefully...
@vsoch
vsoch approved these changes Mar 26, 2020
View changes
Copy link
Member

vsoch left a comment

Great job @danielskatz ! See, all green now, I appreciate your extra little bits of work to remove the now broken urls, and add the newsletters to the whitelist.
@vsoch vsoch merged commit 901e8d5 into master Mar 26, 2020
2 checks passed
2 checks passed
urlcheck
Details
ci/circleci: build-site Your tests passed on CircleCI!
Details
@vsoch vsoch deleted the danielskatz-patch-1 branch Mar 26, 2020
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

danielskatz commented Mar 26, 2020

thanks for walking through this with me
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsoch vsoch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@danielskatz @vsoch
You can’t perform that action at this time.