Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove WriteGraph; resolves #439. #441
Open
Conversation
This comment has been minimized.
This comment has been minimized.
|
Documentation PR: archivesunleashed/aut-docs#54 |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 13, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 77.41% 75.55% -1.87%
==========================================
Files 41 40 -1
Lines 1519 1395 -124
Branches 278 265 -13
==========================================
- Hits 1176 1054 -122
Misses 218 218
+ Partials 125 123 -2 |
This comment has been minimized.
This comment has been minimized.
|
@ianmilligan1 @SinghGursimran If this is merged, it will make #397 unnecessary. Before we do merge, let me finish archivesunleashed/aut-docs#34. Should be straightforward now that #437 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedApr 13, 2020
GitHub issue(s): #439
What does this Pull Request do?
Removes
WriteGraphas it is redundant, and not as fully fleshed out asWriteGraphmlandWriteGEXF.How should this be tested?
Additional Notes:
Rationale is more fully fleshed out here.