Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak hasDate to handle Seq. #430

Merged
merged 6 commits into from Mar 23, 2020
Merged

Tweak hasDate to handle Seq. #430

merged 6 commits into from Mar 23, 2020
+17 −1

Conversation

@ruebot
Copy link
Member

ruebot commented Mar 23, 2020

GitHub issue(s):

What does this Pull Request do?

Follow on to #429, Tweak hasDate to handle Seq.

How should this be tested?

  • TravisCI

...and if you want, something like:

import io.archivesunleashed._
import io.archivesunleashed.df._

val dates = Array("2008", "200908", "20070502")

RecordLoader.loadArchives("/home/nruest/Projects/aut/sample-data/geocities", sc)
  .all()
  .select($"url", $"crawl_date")
  .filter(!hasDate($"crawl_date", lit(dates)))
  .show(10, false)
ruebot added 5 commits Feb 10, 2020
@ruebot
[skip travis] Add pre-print link to README.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
572d217
@ruebot
Merge branch 'master' of github.com:archivesunleashed/aut
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
21c3c08
@ruebot
Merge branch 'master' of github.com:archivesunleashed/aut
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
6a10f4c
@ruebot
Merge branch 'master' of github.com:archivesunleashed/aut
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
5e34e3b
@ruebot
Tweak hasDate to handle Seq.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
fd07392 
- Addresses #425
- Add test for hasDate
@ruebot ruebot requested a review from ianmilligan1 Mar 23, 2020
@ruebot ruebot changed the title Issue 425 dates Tweak hasDate to handle Seq. Mar 23, 2020
@ruebot ruebot mentioned this pull request Mar 23, 2020
Open
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Mar 23, 2020 •
edited

Codecov Report

Merging #430 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          41       41           
  Lines        1534     1534           
  Branches      283      282    -1     
=======================================
  Hits         1192     1192           
  Misses        217      217           
  Partials      125      125
@SinghGursimran
SinghGursimran reviewed Mar 23, 2020
View changes
src/main/scala/io/archivesunleashed/df/package.scala Outdated Show resolved Hide resolved
@ruebot
review
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
832ad18
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

ruebot commented Mar 23, 2020

Documentation PR archivesunleashed/aut-docs#48
@ianmilligan1
ianmilligan1 approved these changes Mar 23, 2020
View changes
Copy link
Member

ianmilligan1 left a comment

Tested with both !hasDate and hasDate, works nicely!
@ianmilligan1 ianmilligan1 merged commit 92b5f2d into master Mar 23, 2020
3 checks passed
3 checks passed
codecov/patch 100.00% of diff hit (target 77.70%)
Details
codecov/project 77.70% (+0.00%) compared to e1d908b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-425-dates branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SinghGursimran SinghGursimran

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ruebot @ianmilligan1 @SinghGursimran
You can’t perform that action at this time.