Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated logic for PDF responses #656
Merged
Conversation
|
|
||
| it "should not redirect when accepting any content type" do | ||
| paper = create(:accepted_paper) | ||
| request.headers["HTTP_ACCEPT"] = "*/*" |
This comment has been minimized.
This comment has been minimized.
arfon
added a commit
that referenced
this pull request
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
arfon commentedDec 27, 2019
This is an update to the controller logic for handling PDF responses. In the past we redirected PDF urls but it turns out that the Google Scholar webcrawler doesn't like this.
With this change, we download the file server-side and send directly to the browser when requesting a PDF, rather than redirecting.
/ cc #130 #637 @labarba