Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTest Dashboard Controller params; resolves #154. #163
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Aug 21, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 34 34
Lines 425 425
=======================================
Hits 387 387
Misses 38 38Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
Hrm. Looks like I have some more research to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedAug 21, 2018
GitHub issue(s):
#154
What does this Pull Request do?
This should cover the missing params coverage in the Dashboard Controller test.
How should this be tested?