Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTranslator for clinicaltrials.gov #2153
Conversation
This comment has been minimized.
This comment has been minimized.
@bwiernik and @adam3smith any input on what item type to use for clinical trials? |
This comment has been minimized.
This comment has been minimized.
bwiernik
commented
Apr 1, 2020
I would use Report for this. |
This comment has been minimized.
This comment has been minimized.
@dhimmel and @agitter two quick questions that I thought you may have answers to:
I looked https://www.who.int/ictrp/How_to_cite.pdf and https://blogs.uoregon.edu/annie/2017/10/25/clinical-trial-apa-format/ but they didn't seem to be conclusive. |
This comment has been minimized.
This comment has been minimized.
bwiernik
commented
Apr 1, 2020
For things like preprints, Zotero translators typically save the last updated date (i.e., the date of the version of the item actually being viewed) as the date. The first submit date could be stored in Extra with the label "Original date:" |
This comment has been minimized.
This comment has been minimized.
Agree on the regular date, but I'd be careful with using |
This comment has been minimized.
This comment has been minimized.
bwiernik
commented
Apr 1, 2020
That's a really good point. "Submitted" might be a better (and rarely used in citation styles) variable. |
This comment has been minimized.
This comment has been minimized.
dhimmel
commented
Apr 1, 2020
Just looking at a random record "SponsorCollaboratorsModule":{
"ResponsibleParty":{
"ResponsiblePartyType":"Principal Investigator",
"ResponsiblePartyInvestigatorFullName":"Chen Xiaoping",
"ResponsiblePartyInvestigatorTitle":"Principal Investigator",
"ResponsiblePartyInvestigatorAffiliation":"Tongji Hospital"
},
"LeadSponsor":{
"LeadSponsorName":"Tongji Hospital",
"LeadSponsorClass":"OTHER"
}
}, Some documentationFrom https://prsinfo.clinicaltrials.gov/definitions.html:
I think perhaps we want everything: the lead investigator, the sponsor, and collaborators. Each one of these could be different authors. I don't know too much about clinical trials however, so would be interested in what others think |
This comment has been minimized.
This comment has been minimized.
Thank you all for the quick responses. Much appreciated! My last commit attempts to incorporate that feedback.
|
This comment has been minimized.
This comment has been minimized.
When I run the tests locally it says that the
i.e. it's getting @adam3smith or someone else experienced with Zotero, any input on this? |
This comment has been minimized.
This comment has been minimized.
Haven't looked at your code, but |
This comment has been minimized.
This comment has been minimized.
Thanks @adam3smith! That worked. All three test are now passing. Ready for review. |
This comment has been minimized.
This comment has been minimized.
bwiernik
commented
Apr 2, 2020
•
A few immediate comments:
|
rdvelazquez commentedApr 1, 2020
•
edited
TODO:
Currently usingusingjournalArticle
but there have been discussions of usingdataset
or creating a new typereport
as recommended by @bwwiernikGot it set up and everything works except for an issue with matching the "extra" fieldAll three tests are passing nowImplement the search (if we think its a feature this should have)I don't see the need for being able to cite all the trials from a particular search of clinicaltrials.gov at this point (could always be added in later if needed,item parsing and other TODOstranslatorType
andbrowserSupport
in the metadata I think these are correct; just following these docscloses #1952
relates to manubot/manubot#216