Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: rf: Receiver function calculation in seismology #1808
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @ThomasLecocq, @seisman it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
👋🏼 @trichter @seisman @ThomasLecocq this is the review thread for the paper. All of our communications will happen here from now on. Both reviewers have checklists at the top of this thread with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 4 weeks. Please let me know if any of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me here (@leouieda) or email me privately if you have any questions/concerns. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@leouieda I should be able to finish the review before this weekend. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@leouieda I've finished my review and my comments have been addressed. The submission now looks good to me. |
This comment has been minimized.
This comment has been minimized.
@seisman Thank you very much for the review! |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
I updated the reference for the telewavesim package, which was recently published in JOSS. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @trichter thanks for the update. Apologies for the delay in this submission. I'll see if we can speed things up after AGU next week. |
This comment has been minimized.
This comment has been minimized.
/ooo December 7 until December 17 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Waiting on a reply from @ThomasLecocq. If we don't hear back, I'll start looking for another reviewer (or probably just assign myself as a reviewer). Thanks for your patience @trichter |
This comment has been minimized.
This comment has been minimized.
wow guyz, sorry for this, noticed I disabled the github notifications a while ago... and @leouieda your emails went to spam... so I masterfully failed my assignment here... Will do this week. Sorry about this. |
This comment has been minimized.
This comment has been minimized.
@ThomasLecocq any updates on this review? |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@leouieda I worked through your posted list:
|
This comment has been minimized.
This comment has been minimized.
@whedon set 0.9.1 as version |
This comment has been minimized.
This comment has been minimized.
OK. 0.9.1 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.3741366 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3741366 is the archive. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1408, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@trichter thank you for implementing these final fixes. It's my pleasure to recommend your submission for publication in JOSS A JOSS Associate Editor-in-Chief will stop by and do the final acceptance and publication (usually quick but please be patient given the current global crisis). @seisman @ThomasLecocq thank for your reviews of this submission! |
This comment has been minimized.
This comment has been minimized.
Thanks @leouieda - I'll take this now |
This comment has been minimized.
This comment has been minimized.
@trichter - there are some small changes in trichter/rf#27 |
This comment has been minimized.
This comment has been minimized.
@danielskatz Thanks for these. I merged your branch. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
Thanks to @ThomasLecocq & @seisman for reviewing, and @leouieda for editing! Congratulations to @trichter! |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedOct 14, 2019
•
edited
Submitting author: @trichter (Tom Eulenfeld)
Repository: https://github.com/trichter/rf
Version: 0.9.1
Editor: @leouieda
Reviewers: @ThomasLecocq, @seisman
Archive: 10.5281/zenodo.3741366
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ThomasLecocq & @seisman, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @leouieda know.
Review checklist for @ThomasLecocq
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @seisman
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper