Skip to content

/ rf

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes in paper #27

Merged
merged 2 commits into from Apr 6, 2020
Merged

small fixes in paper #27

merged 2 commits into from Apr 6, 2020
+5 −5

Conversation

@danielskatz
Copy link
Contributor

danielskatz commented Apr 6, 2020

No description provided.

danielskatz added 2 commits Apr 6, 2020
@danielskatz
small fixes in paper
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7cdb43b
@danielskatz
minor fix in bib
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
b6fe255
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

danielskatz commented Apr 6, 2020

re JOSS review - openjournals/joss-reviews#1808
@danielskatz danielskatz mentioned this pull request Apr 6, 2020
Closed
38 of 38 tasks complete
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Apr 6, 2020 •
edited

Codecov Report

Merging #27 into master will decrease coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   90.76%   89.55%   -1.22%     
==========================================
  Files          17       17              
  Lines        1982     1982              
==========================================
- Hits         1799     1775      -24     
- Misses        183      207      +24
Impacted Files Coverage Δ
rf/tests/test_batch.py 91.02% <0.00%> (-6.42%) ⬇️
rf/rfstream.py 90.95% <0.00%> (-2.85%) ⬇️
rf/tests/test_rfstream.py 96.81% <0.00%> (-1.92%) ⬇️
rf/deconvolve.py 82.66% <0.00%> (-1.34%) ⬇️
rf/batch.py 83.54% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad46591...b6fe255. Read the comment docs.
@trichter

This comment has been minimized.

Sign in to view
Copy link
Owner

trichter commented Apr 6, 2020

Thank you for these fixes.
@trichter trichter merged commit e514b7f into trichter:master Apr 6, 2020
@danielskatz danielskatz deleted the danielskatz:patch-1 branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@danielskatz @codecov-io @trichter
You can’t perform that action at this time.