Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Update kaminari: 1.1.1 → 1.2.0 (minor) #365

Merged
merged 1 commit into from Jan 31, 2020

Conversation

@depfu
Copy link
Contributor

depfu bot commented Jan 31, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ kaminari (1.1.1 → 1.2.0) · Repo · Changelog

Release Notes

1.2.0 (from changelog)

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ crass (indirect, 1.0.5 → 1.0.6) · Repo · Changelog

Release Notes

1.0.6

  • Number values are now limited to a maximum of Float::MAX and a minimum of negative Float::MAX. (#11)

  • Added project metadata to the gemspec. (#9 - @orien)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 4 commits:

↗️ i18n (indirect, 1.7.0 → 1.8.2) · Repo · Changelog

Release Notes

1.8.2

  • Restoration of #499 via #509 - deep_merge! & deep_merge methods appear again in the Hash refinement.
  • An issue was introduced in v1.7.0 where some translations were returned as hashes, see #510. This was fixed in 1b5e345, and is available in this release.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 42 commits:

↗️ kaminari-actionview (indirect, 1.1.1 → 1.2.0) · Repo · Changelog

Release Notes

1.2.0 (from changelog)

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ kaminari-activerecord (indirect, 1.1.1 → 1.2.0) · Repo · Changelog

Release Notes

1.2.0 (from changelog)

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ kaminari-core (indirect, 1.1.1 → 1.2.0) · Repo · Changelog

Release Notes

1.2.0 (from changelog)

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.13.0 → 5.14.0) · Repo · Changelog

Release Notes

5.14.0 (from changelog)

  • 2 minor enhancements:

    • Block-assertions (eg assert_output) now error if raised inside the block. (casperisfine)

    • Changed assert_raises to only catch Assertion since that covers Skip and friends.

  • 3 bug fixes:

    • Added example for value wrapper with block to Expectations module. (stomar)

    • Fixed use of must/wont_be_within_delta on Expectation instance. (stomar)

    • Renamed UnexpectedError#exception to #error to avoid problems with reraising. (casperisfine)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 8 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Jan 31, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   89.15%   89.15%           
=======================================
  Files          35       35           
  Lines         636      636           
=======================================
  Hits          567      567           
  Misses         69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc2086...84be7a2. Read the comment docs.

@ruebot ruebot merged commit aad3ba5 into master Jan 31, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 9cc2086...84be7a2
Details
codecov/project 89.15% remains the same compared to 9cc2086
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/kaminari-1.2.0 branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.