Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upimproved colour scale for topic orgs map #1085
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Would be great to arrange the colours such that the least occupied layer (i.e. highest numbers) are always displayed on top. May require changing the direction of the IF clause. |
This comment has been minimized.
This comment has been minimized.
I played around with color rearrangement, but it does not seem to be possible to specify the order in which the layers are being stacked for display. |
This comment has been minimized.
This comment has been minimized.
In terms of changing direction of the IF clause, that query is here. |
The query works for me. In that sense the patch looks fine. However, why is the number of dots less? Also, I would suggest to add a legend outside the |
This comment has been minimized.
This comment has been minimized.
Not sure what you mean by the fewer dots. If that refers to the two pics in #1085 (comment) , then they do not have to be compared against each other but against the two pics in #1084 (comment) , which represent two different use cases behind the two changes in the patch (removing the LIMIT, adding 1 as another step). |
This comment has been minimized.
This comment has been minimized.
Not sure about the explanation of the dot colour either, but I just added #1087 for that. |
This comment has been minimized.
This comment has been minimized.
Oh, sorry, I thought they were before after :) |
This comment has been minimized.
This comment has been minimized.
Ah. awesome. @Daniel-Mietchen, you can actually push additional patches to existing pull requests. I will see if I can merge in #1087 into this branch. |
This comment has been minimized.
This comment has been minimized.
I purposefully kept the explanation commit separate, since I am not sure that's what we need. But I take your merge as a yes and am merging all of it into master now. |
Daniel-Mietchen commentedMar 24, 2020
Initial attempt to address #1084