Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Matchbox implementations for Scala #415

Merged
merged 2 commits into from Jan 21, 2020
Merged

Remaining Matchbox implementations for Scala #415

merged 2 commits into from Jan 21, 2020
+115 −0

Conversation

@SinghGursimran
Copy link
Collaborator

SinghGursimran commented Jan 21, 2020 •
edited

Remaining Matchbox implementations for Scala

#223

For Testing

ExtractImageDetailsDF

import io.archivesunleashed._
import io.archivesunleashed.app._

val df = RecordLoader.loadArchives("./src/test/resources/arc/example.arc.gz",sc)
					 .keepImages()
					 .all()

ExtractImageDetailsDF(df).show(10)
g285sing
matchbox_final
Loading status checks…
8e0df43
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 21, 2020 •
edited

Codecov Report

Merging #415 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage    77.7%   77.96%   +0.25%     
==========================================
  Files          40       41       +1     
  Lines        1552     1570      +18     
  Branches      292      292              
==========================================
+ Hits         1206     1224      +18     
  Misses        218      218              
  Partials      128      128
g285sing
Tests
Loading status checks…
d474a5e
@SinghGursimran SinghGursimran marked this pull request as ready for review Jan 21, 2020
@ruebot
ruebot approved these changes Jan 21, 2020
View changes
@ruebot ruebot merged commit 71b459c into archivesunleashed:master Jan 21, 2020
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 77.7%)
Details
codecov/project 77.96% (+0.25%) compared to 9e357cc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruebot ruebot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SinghGursimran @ruebot
You can’t perform that action at this time.