Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating Java install instructions for MacOS, resolves #445 #455
+4
−2
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
=======================================
Coverage 76.59% 76.59%
=======================================
Files 49 49
Lines 1457 1457
Branches 279 279
=======================================
Hits 1116 1116
Misses 211 211
Partials 130 130 |
|
looks great! thanks @ianmilligan1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ianmilligan1 commentedApr 23, 2020
GitHub issue(s):
#445
What does this Pull Request do?
Updates the README to provide the
brewinstall command that works for @SamFritz, as well as changing links from the Oracle Java site to the OpenJDK.How should this be tested?
Prose review.
Interested parties
@ruebot @SamFritz