Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Spark job to run auk jobs via spark-submit in parallel. #393
Conversation
- Update Rubocop config - Remove AUK Notebooks link - Update application config example - Tweak analyzed date helper to use filtered text to get date (last item that is ran in the pipeline) - Change name of "Full Text" derivative to "Web Page Text" since full text is misleading - Multiply data analyzed total by 3 since that's what we're doing in reality
codecov
bot
commented
Apr 28, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 35 35
Lines 623 623
=======================================
Hits 557 557
Misses 66 66
Continue to review full report at Codecov.
|
|
Looks good to me. One minor text suggestion, but I'm also worried my suggestion is slightly too wordy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedApr 28, 2020
that is ran in the pipeline)
text is misleading
reality
@ianmilligan1 @SamFritz lots of changes here. Don't worry about testing it. I just want to make sure you're ok with the name changes for "Full-text", and the additional text changes. Once you're good with it, let me know and I'll merge, and get over to production.