Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDetectMimeTypeTika.scala - do we actually use it? #330
Comments
ruebot
added a commit
that referenced
this issue
Jul 25, 2019
ruebot
added
clean-up
in progress
labels
Jul 25, 2019
This comment has been minimized.
This comment has been minimized.
|
I was using it for binary extraction, since the MimeType recorded in the WARCs is not always reliable. (I haven't committed the binary extraction methods yet, in part because I think I was having some Tika related memory issues.) |
This comment has been minimized.
This comment has been minimized.
ruebot
added
question
and removed
clean-up
in progress
labels
Jul 31, 2019
This comment has been minimized.
This comment has been minimized.
|
I'll mark this as answered and close it since we've captured the meaning well in the discussion on #302. |
ruebot
closed this
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ruebot commentedJul 25, 2019
•
edited
Following up on the question in Slack.
What's the use case for
DetectMimeTypeTika? We usegetMimeTypeelsewhere, but I'm a little confused how it actually works.The only thing that I can see that calls it is a test.
I was digging through the Git history here and on the Warcbase repo, and can't really tell what it's used for, but it goes way back to Pig days. Maybe it's just legacy and we can remove it?
@lintool @jrwiebe @ianmilligan1 thoughts?