Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tweet utils. #323

Merged
merged 2 commits into from Jul 15, 2019
+0 −393

Conversation

Reviewers

@ianmilligan1 ianmilligan1

@lintool lintool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @codecov-io @ianmilligan1
@ruebot
Copy link
Member

commented Jul 8, 2019

GitHub issue(s):

What does this Pull Request do?

Remove all Tweet analysis functionality.

How should this be tested?

  • TravisCI

Additional Notes:

Need to remove documentation on archivesunleashed.org for next release.
@ruebot
Remove Tweet utils. 
- Resolves #322
- Resolves #206
- Resolves #194
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
bed9f0e

@ruebot ruebot requested review from lintool and ianmilligan1 Jul 8, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Jul 8, 2019 •
edited

Codecov Report

Merging #323 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   75.95%   74.84%   -1.12%     
==========================================
  Files          41       39       -2     
  Lines        1148     1117      -31     
  Branches      200      197       -3     
==========================================
- Hits          872      836      -36     
- Misses        209      215       +6     
+ Partials       67       66       -1
Impacted Files Coverage Δ
src/main/scala/io/archivesunleashed/package.scala 84.54% <ø> (-0.28%) ⬇️
...archivesunleashed/matchbox/ExtractAtMentions.scala 0% <0%> (-100%) ⬇️
...la/io/archivesunleashed/matchbox/ExtractUrls.scala 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce59c8...5d118cf. Read the comment docs.
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 8, 2019

Will test today or tomorrow, and I can stage the archivesunleashed.org PR as well.
@ruebot
Merge branch 'master' into issue-322
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5d118cf
@ianmilligan1

ianmilligan1 approved these changes Jul 8, 2019
View changes

Copy link
Member

left a comment

Builds nicely and I think, as noted in #322, this makes sense for the future of the AUT. Approved on my end.

That said, looking forward to hearing @lintool's thoughts as I know he's used these in the past.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 10, 2019

@lintool can you hit the button?

@ianmilligan1 ianmilligan1 referenced this pull request Jul 11, 2019

Open

Update Documentation for 0.18.0 #77

@ianmilligan1 ianmilligan1 merged commit 20ffeeb into master Jul 15, 2019
2 of 3 checks passed

2 of 3 checks passed

codecov/project 74.84% (-1.12%) compared to 4ce59c8
Details
codecov/patch Coverage not affected when comparing 4ce59c8...5d118cf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the issue-322 branch Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.