Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRestyle UDFs in the context of DataFrames #427
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Please let me know if this format is fine so I will change the other API's as well. It requires a bit more function calls on the user side. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Mar 6, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
- Coverage 78.15% 77.77% -0.38%
==========================================
Files 41 41
Lines 1584 1602 +18
Branches 299 303 +4
==========================================
+ Hits 1238 1246 +8
- Misses 218 228 +10
Partials 128 128 |
This comment has been minimized.
This comment has been minimized.
Format appears right, but I believe one of the goals was to collapse the keep/discard into has. So, it should be:
@lintool sound good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SinghGursimran commentedMar 6, 2020
•
edited
Restyle UDFs in the context of DataFrames.
#425