Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to unselect some of the languages in which glosses are shown for a particular lexeme #40

Open
Daniel-Mietchen opened this issue May 19, 2020 · 5 comments

Comments

@Daniel-Mietchen
Copy link

@Daniel-Mietchen Daniel-Mietchen commented May 19, 2020

E.g. in this example, I would have liked to exclude the rather unspecific Dutch gloss from the "It's a match" set. Since such filtering was not available and lexemes cannot be specified by the user yet (e.g. as per #33 ), I went for "Skip" (but then, the tool froze, as per #36).

Screen Shot 2020-05-19 at 19 29 19

It also seems to be common that some of the languages discuss different things, e.g. here, the Russian description is about military strategy, while the other languages are about strategy more general:
Screen Shot 2020-05-19 at 17 39 53

Also common are cases where the descriptions in some languages are about the lexeme at hand, but some are about disambiguation pages (don't have a screenshot at hand).

Nudin added a commit that referenced this issue May 20, 2020
Gives a workaround for #40
@Nudin
Copy link
Owner

@Nudin Nudin commented May 20, 2020

Adding this "properly" is more work than I currently can/want to invest, but I added a quick fix that glosses that are empty will be ignored. This way you can unselect them by using the edit-mode and leave the input field empty (resulting in "" being shown).

@Nudin
Copy link
Owner

@Nudin Nudin commented May 20, 2020

PS: Better control if it works correctly the first few times, since I havn't tested it.

@waldyrious
Copy link
Contributor

@waldyrious waldyrious commented May 21, 2020

using the edit-mode

Wow! Sorry, this is off-topic, but I just want to mention that I never realized the ✍️ symbol was a button until I read this comment! I thought it was just decoration. Could it be styled like a button, perhaps? (Like the ones at the bottom, but smaller, of course.) Or at least the cursor should change to a hand when it's hovered. I'd be happy to submit a PR with that change if you agree.

@Nudin
Copy link
Owner

@Nudin Nudin commented May 21, 2020

Wow! Sorry, this is off-topic, but I just want to mention that I never realized the ✍️ symbol was a button until I read this comment! I thought it was just decoration. Could it be styled like a button, perhaps? (Like the ones at the bottom, but smaller, of course.) Or at least the cursor should change to a hand when it's hovered. I'd be happy to submit a PR with that change if you agree.

That is a good point! Especially the mouse-pointer and a hover-text should be added not only for this but for all buttons. I think I tried making it look more like a button but wasn't happy with it, but if you manage to make them not look like Windows 98 I'll happily merge it.

@Daniel-Mietchen
Copy link
Author

@Daniel-Mietchen Daniel-Mietchen commented May 24, 2020

The quick fix works OK so far. The only issue is that this requires three actions in order to get a gloss in one language ignored: click to open gloss editor, edit gloss, click to close editor. I had cases where the suggested text was appropriate only in one language but did not fit in multiple others. In such cases, I usually skipped — no fun to go through several dozens of actions in order to actually have two intended edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.