New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template. #85

Merged
merged 3 commits into from Oct 5, 2017

Conversation

Projects
None yet
3 participants
@ruebot
Member

ruebot commented Oct 5, 2017

No description provided.

ruebot and others added some commits Oct 5, 2017

Some minor changes to make it clearer for newbies
Defining PR acronym, making issue # explicit
@codecov

This comment has been minimized.

codecov bot commented Oct 5, 2017

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          41       41           
  Lines         821      821           
  Branches      147      147           
=======================================
  Hits          379      379           
  Misses        395      395           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834d7f6...93e0ddc. Read the comment docs.

@ianmilligan1

Looks good! I made a few alterations (feel free to roll back or change, of course), but I think this is good to go once tests pass.

@ianmilligan1

This comment has been minimized.

Member

ianmilligan1 commented Oct 5, 2017

@lintool as @ruebot and I have both contributed to this PR, could you review/comment and merge if you approve of the pull review template?

@lintool

lintool approved these changes Oct 5, 2017

lg

@lintool lintool merged commit aac74d9 into master Oct 5, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 834d7f6...93e0ddc
Details
codecov/project 46.16% remains the same compared to 834d7f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ruebot ruebot deleted the pr-template branch Oct 5, 2017

greebie added a commit that referenced this pull request Oct 5, 2017

ruebot added a commit that referenced this pull request Oct 6, 2017

Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63,
…#64 & #66 (#87)

* Add tests for remove Tuples, CreateGDF and RemoveHTML

* Add RemoveHttpHeader test.

* Add license header to tests.

* Issues #56, #57, #58, #59, #61, #62

* resolves Issue #85 (JsonUtil)

* Fix issue # 64 (ExtractDate coverage)

* Resolve Issue #63 (Extract Domain coverage)

* Fix error caused by repeated test names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment