Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: multivar_horner: A Python package for computing Horner factorisations of multivariate polynomials #2224

Open
whedon opened this issue May 22, 2020 · 24 comments
Assignees

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented May 22, 2020

Submitting author: @MrMinimal64 (Jannik Michelfeit)
Repository: https://github.com/MrMinimal64/multivar_horner
Version: v.2.0.0
Editor: @dpsanders
Reviewer: Pending
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @MrMinimal64. Currently, there isn't an JOSS editor assigned to your paper.

@MrMinimal64 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label May 22, 2020
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 22, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 22, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.07 s (498.1 files/s, 70070.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            764            967           1832
reStructuredText                12            419            168            389
TeX                              2             46              0            325
Markdown                         1             55              0            100
YAML                             3             20             17             37
INI                              1              9              1             22
make                             1              4              7              9
Bourne Shell                     2              5              0              9
-------------------------------------------------------------------------------
SUM:                            37           1322           1160           2723
-------------------------------------------------------------------------------


Statistical information for the repository '2224' was gathered on 2020/05/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
MrMinimal64                     38          8971           5410          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
MrMinimal64                3563           39.7          6.0               17.32
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 22, 2020

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 22, 2020

Reference check summary:

OK DOIs

- 10.1109/MCSE.2011.37 is OK
- 10.1145/2833157.2833162 is OK

MISSING DOIs

- https://doi.org/10.1098/rstl.1819.0023 may be missing for title: XXI. A new method of solving numerical equations of all orders, by continuous approximation
- https://doi.org/10.1007/978-3-030-01177-2_5 may be missing for title: Fast Interpolation and Fourier Transform in High-Dimensional Spaces
- https://doi.org/10.1145/980175.980179 may be missing for title: Greedy algorithms for optimizing multivariate Horner schemes
- https://doi.org/10.1007/s006070070002 may be missing for title: On the multivariate Horner scheme II: running error analysis
- https://doi.org/10.15807/jorsj.51.29 may be missing for title: Efficient evaluation of polynomials and their partial derivatives in homotopy continuation methods
- https://doi.org/10.1090/s0025-5718-1990-0993925-1 may be missing for title: Evaluation of multivariate polynomials and their derivatives
- https://doi.org/10.1016/j.cpc.2013.05.008 may be missing for title: Improving multivariate Horner schemes with Monte Carlo tree search
- https://doi.org/10.1007/978-3-642-15582-6_55 may be missing for title: Efficient evaluation of large polynomials

INVALID DOIs

- None
@arfon
Copy link
Member

@arfon arfon commented May 23, 2020

👋 @MrMinimal64 - thanks for your submission to JOSS. Could you please add a few sentences to your paper to help those less intensely involved in mathematics understand the downstream applications of this work? That would help to assess the impact of the effort and help clarify the range of research users who would be impacted by this.

Also, as described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the week we've had > 50 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@arfon arfon added the waitlisted label May 23, 2020
@MrMinimal64
Copy link

@MrMinimal64 MrMinimal64 commented May 23, 2020

Hello @arfon, thanks for your quick response. Could you tell me which parts I should clarify or which parts are unclear? I thought I had described the advantages and potential use cases of the package extensively in the first section "Summary". The following sections give a more detailed explanation of the implemented approach and underpin the advantages with benchmarks.

I am looking forward to your review.

@MrMinimal64
Copy link

@MrMinimal64 MrMinimal64 commented May 23, 2020

should I suggest reviewers myself?

@arfon
Copy link
Member

@arfon arfon commented May 24, 2020

Hello @arfon, thanks for your quick response. Could you tell me which parts I should clarify or which parts are unclear?

I think a little more detail in the summary section would be useful. For example, are there applied research fields where the factorisation of multivariate polynomials is a key aspect of the research work/analysis?

should I suggest reviewers myself?

Yes, please go ahead but as I mentioned above, we won't actually begin the review process until an editor is assigned to this paper which may be some time due to a large backlog of submissions.

@MrMinimal64
Copy link

@MrMinimal64 MrMinimal64 commented May 25, 2020

I clarified the possible application of this package in the paper and added example applications where the package is already being used.

@MrMinimal64
Copy link

@MrMinimal64 MrMinimal64 commented May 25, 2020

Based on the topics (applied mathematics, numerical analysis...) and preferred language (Python) they provided, I suggest the following reviewers:

munkm
SebastianoF
diehlpk
crstnbr
mstimberg
cpgr
fccoelho
bonh
dglmoore
@MrMinimal64
Copy link

@MrMinimal64 MrMinimal64 commented May 28, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

PDF failed to compile for issue #2224 with the following error:

Error reading bibliography ./paper.bib (line 72, column 3):
unexpected "y"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@MrMinimal64
Copy link

@MrMinimal64 MrMinimal64 commented May 28, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

@danielskatz
Copy link

@danielskatz danielskatz commented May 28, 2020

👋 @dpsanders - would you be able to edit this submission?

@danielskatz
Copy link

@danielskatz danielskatz commented May 28, 2020

@whedon invited @dpsanders as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
@danielskatz
Copy link

@danielskatz danielskatz commented May 28, 2020

@whedon invite @dpsanders as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

@dpsanders has been invited to edit this submission.

@dpsanders
Copy link

@dpsanders dpsanders commented May 28, 2020

@danielskatz Yes sure.

@whedon assign @dpsanders as editor

@dpsanders
Copy link

@dpsanders dpsanders commented May 28, 2020

@whedon assign @dpsanders as editor

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

OK, the editor is @dpsanders

@dpsanders
Copy link

@dpsanders dpsanders commented May 28, 2020

@whedon check repository

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.17 s (215.5 files/s, 30338.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            761            961           1829
reStructuredText                12            422            168            391
TeX                              2             46              0            332
Markdown                         1             53              0            106
YAML                             3             20             17             37
INI                              1              9              1             22
make                             1              4              7              9
Bourne Shell                     2              5              0              9
-------------------------------------------------------------------------------
SUM:                            37           1320           1154           2735
-------------------------------------------------------------------------------


Statistical information for the repository '2224' was gathered on 2020/05/28.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
MrMinimal64                     39          8975           5426          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
MrMinimal64                3551           39.6          6.8               17.21
@danielskatz danielskatz removed the waitlisted label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.