Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pypillometry: A Python package for pupillometric analyses #2269

Open
whedon opened this issue May 28, 2020 · 15 comments
Open

[PRE REVIEW]: pypillometry: A Python package for pupillometric analyses #2269

whedon opened this issue May 28, 2020 · 15 comments

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented May 28, 2020

Submitting author: @ihrke (Matthias Mittner)
Repository: https://github.com/ihrke/pypillometry
Version: v1.0.0
Editor: Pending
Reviewer: Pending
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @ihrke. Currently, there isn't an JOSS editor assigned to your paper.

@ihrke if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label May 28, 2020
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.88 s (76.4 files/s, 35171.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            21            462              0           8648
JavaScript                       9           2201           2234           8331
Python                          14            597           1361           1683
CSS                              3            210             42            837
Jupyter Notebook                 8              0           3237            441
reStructuredText                 7            145            127            115
TeX                              1              9              0             97
Markdown                         2             15              0             32
make                             1              4              7              9
YAML                             1              0              2              7
-------------------------------------------------------------------------------
SUM:                            67           3643           7010          20200
-------------------------------------------------------------------------------


Statistical information for the repository '2269' was gathered on 2020/05/28.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Matthias Mittner                62         17207            800          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Matthias Mittner          16407           95.4          5.7               15.68
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Reference check summary:

OK DOIs

- 10.3758/s13428-020-01374-8 is OK

MISSING DOIs

- https://doi.org/10.5334/joc.18 may be missing for title: Pupillometry: Psychology, physiology, and function
- https://doi.org/10.1126/science.132.3423.349 may be missing for title: Pupil size as related to interest value of visual stimuli
- https://doi.org/10.1146/annurev.neuro.28.061604.135709 may be missing for title: An integrative theory of locus coeruleus-norepinephrine function: adaptive gain and optimal performance
- https://doi.org/10.3758/cabn.10.2.252 may be missing for title: Pupil diameter tracks changes in control state predicted by the adaptive gain theory of locus coeruleus function

INVALID DOIs

- None
@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

@danielskatz
Copy link

@danielskatz danielskatz commented May 28, 2020

👋 @ihrke - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS last week, we've had > 60 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

(In the meantime, feel free to make fixes to the paper, such as adding missing DOIs, etc. - add @whedon generate pdf as a new comment in this thread to build the pdf)

@ihrke
Copy link

@ihrke ihrke commented May 28, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

PDF failed to compile for issue #2269 with the following error:

Error reading bibliography ./paper.bib (line 9, column 3):
unexpected "p"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@ihrke
Copy link

@ihrke ihrke commented May 28, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

@ihrke
Copy link

@ihrke ihrke commented May 28, 2020

@whedon check references

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Reference check summary:

OK DOIs

- 10.3758/s13428-020-01374-8 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.5334/joc.18 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1126/science.132.3423.349 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1146/annurev.neuro.28.061604.135709 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.3758/cabn.10.2.252 is INVALID because of 'https://doi.org/' prefix
@ihrke
Copy link

@ihrke ihrke commented May 28, 2020

@whedon check references

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Reference check summary:

OK DOIs

- 10.5334/joc.18 is OK
- 10.1126/science.132.3423.349 is OK
- 10.3758/s13428-020-01374-8 is OK
- 10.1146/annurev.neuro.28.061604.135709 is OK
- 10.3758/cabn.10.2.252 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@ihrke
Copy link

@ihrke ihrke commented May 28, 2020

@whedon generate pdf

@whedon
Copy link
Collaborator Author

@whedon whedon commented May 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.