Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFrame udf tests. #474

Merged
merged 2 commits into from May 28, 2020
Merged

Add DataFrame udf tests. #474

merged 2 commits into from May 28, 2020
+120 −0

Conversation

@ruebot
Copy link
Member

ruebot commented May 28, 2020

GitHub issue(s): #473

What does this Pull Request do?

Add DataFrame udf tests.

How should this be tested?

  • TravisCI
  • CodeCov goes up
@ruebot
Add DataFrame udf tests.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
7b13c21 
- Resolves #473
@ruebot ruebot requested a review from ianmilligan1 May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020 •
edited

Codecov Report

Merging #474 into master will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   83.50%   83.88%   +0.38%     
==========================================
  Files          44       44              
  Lines        1297     1297              
  Branches      250      250              
==========================================
+ Hits         1083     1088       +5     
+ Misses         85       80       -5     
  Partials      129      129
@ruebot
Add computeImageSize test.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
87baa0d
@ruebot ruebot marked this pull request as ready for review May 28, 2020
@ruebot
Copy link
Member Author

ruebot commented May 28, 2020

Cool. Good to go now: https://codecov.io/gh/archivesunleashed/aut/src/87baa0de3ade294626981dde3b508375c5bbd957/src/main/scala/io/archivesunleashed/udfs/package.scala
@ruebot
Copy link
Member Author

ruebot commented May 28, 2020

All that for 0.38% 🤣
@ianmilligan1
ianmilligan1 approved these changes May 28, 2020
View changes
@ianmilligan1 ianmilligan1 merged commit 4cd90dc into master May 28, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 9815ea4...87baa0d
Details
codecov/project 83.88% (+0.38%) compared to 9815ea4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-473 branch May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
Test coverage
Awaiting triage
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.