Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame field names: open thread #229

Closed
lintool opened this issue May 18, 2018 · 2 comments

Comments

3 participants
@lintool
Copy link
Member

commented May 18, 2018

Open thread for discussion: naming conventions for DF fields? Options include:

  1. CamelCase: e.g., SourceUrl
  2. smallCamelCase: e.g., sourceUrl
  3. Lower-case, underscore-style: e.g., source_url

I've been doing (1), but now that I look at the DF queries, I think (3) will "look better". I don't have strong opinions either way, but we should decide on something and make everything consistent.

BTW, the heuristic of "use whatever is the dominant convention in the native language" doesn't help here... because DFs will be natively implemented in Scala, but I assume frequently access in Python.

@ruebot

This comment has been minimized.

Copy link
Member

commented May 18, 2018

Option 3 is what is enforced by Rubocop on our RoR projects.

@ianmilligan1

This comment has been minimized.

Copy link
Member

commented May 18, 2018

Let's go with Option 3 then for similarity across projects? (and I think it'll look nice too)

@ruebot ruebot added this to In Progress in DataFrames and PySpark May 21, 2018

@ruebot ruebot added this to To Do in 1.0.0 Release of AUT Aug 13, 2018

@ruebot ruebot moved this from In Progress to ToDo in DataFrames and PySpark Aug 13, 2018

@ruebot ruebot added the discussion label Aug 20, 2018

ruebot added a commit that referenced this issue Jul 17, 2019

1.0.0 Release of AUT automation moved this from To Do to Done Jul 18, 2019

DataFrames and PySpark automation moved this from ToDo to In review Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.