Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text column to imageGraph (imageLinks) #420

Closed
ruebot opened this issue Feb 10, 2020 · 2 comments
Closed

Add alt text column to imageGraph (imageLinks) #420

ruebot opened this issue Feb 10, 2020 · 2 comments
Assignees
@ruebot
Labels
DataFrames Scala enhancement

Comments

@ruebot
Copy link
Member

@ruebot ruebot commented Feb 10, 2020

Let's add a new column to .imageGraph(); the text of the alt attribute if it exists in an image tag.
@lintool

This comment has been minimized.

Sign in to view
Copy link
Member

@lintool lintool commented Feb 10, 2020

.imageGraph() or .imagegraph()? The latter would be consistent with .webgraph(). Or alternatively, rename .webgraph() to .linkgraph() and you get a nice {image, link} symmetry.
@lintool lintool mentioned this issue Feb 10, 2020
Merged
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

@ianmilligan1 ianmilligan1 commented Feb 10, 2020

FWIW I like .imagegraph()
@ruebot ruebot self-assigned this Feb 10, 2020
ruebot added a commit that referenced this issue Feb 10, 2020
@ruebot
Add img alt text to imagegraph(); resolves #420.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
6f5c81c 
- Update ExtractImageLinksRDD to grab alt text
- Add alt_text column to imagegraph
- Update tests
@ruebot ruebot mentioned this issue Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
DataFrames Scala enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@ruebot @lintool @ianmilligan1
You can’t perform that action at this time.