Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tabDelimit #471

Closed
ianmilligan1 opened this issue May 27, 2020 · 2 comments
Closed

Remove tabDelimit #471

ianmilligan1 opened this issue May 27, 2020 · 2 comments
Assignees
@ruebot
Labels
Scala clean-up rdd tests
Projects
1.0.0 Release of AUT Test coverage

Comments

@ianmilligan1
Copy link
Member

@ianmilligan1 ianmilligan1 commented May 27, 2020

We have some legacy tabDelimit code that was used for the "Export as TSV" functionality in warcbase, and then the Archives Unleashed Toolkit. It is only used on the RDD side.

As we support exporting graphs as csv, graphml, and gexf, I think we have enough export functionality.

We should remove this from TupleFormatter and TupleFormatterTest.
@ianmilligan1
Copy link
Member Author

@ianmilligan1 ianmilligan1 commented May 27, 2020

FWIW the last time the Export as TSV functionality appeared in our docs was here in 0.18.0
@ruebot
Copy link
Member

@ruebot ruebot commented May 27, 2020

Oh wow! It's been a while then.

It'll be nice to get rid of all the shapeless stuff too. That was causing some issues with the Hadoop 3.2 PR (#385). All the NER removal helps on that one too. 🥳
ruebot added a commit that referenced this issue May 27, 2020
@ruebot
Remove tabDelimit.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
dc143b1 
- Resolves #471
- Remove TupleFormatter (tabDelimit functionality)
- Remove shapeless from pom
@ruebot ruebot mentioned this issue May 27, 2020
Merged
ruebot added a commit that referenced this issue May 27, 2020
@ruebot
Remove tabDelimit.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
d1b0620 
- Resolves #471
- Resolves #59
- Remove TupleFormatter (tabDelimit functionality)
- Remove shapeless from pom
@ianmilligan1 ianmilligan1 added this to Done in 1.0.0 Release of AUT via automation May 27, 2020
ianmilligan1 pushed a commit that referenced this issue May 27, 2020
@ruebot
Remove tabDelimit. (#472)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9815ea4 
- Resolves #471
- Resolves #59
- Remove TupleFormatter (tabDelimit functionality)
- Remove shapeless from pom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
Scala clean-up rdd tests
Projects
1.0.0 Release of AUT
  
Done
Test coverage
Awaiting triage
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove tabDelimit.
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.