Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove Python UDF methods out of their own class. #475
Merged
Conversation
codecov
bot
commented
May 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 44 44
Lines 1297 1297
Branches 250 250
=======================================
Hits 1088 1088
Misses 80 80
Partials 129 129 |
| @@ -1,5 +1,39 @@ | |||
| from aut.app import Extract_Popular_Images, Write_Gexf, Write_Graphml | |||
| from aut.common import WebArchive | |||
| from aut.udfs import Udf | |||
| from aut.udfs import ( | |||
| compute_image_size, | |||
This comment has been minimized.
This comment has been minimized.
|
|
||
| __all__ = ["Extract_Popular_Images", "Udf", "WebArchive", "Write_Gexf", "Write_Graphml"] | ||
| __all__ = [ | ||
| "Extract_Popular_Images", |
This comment has been minimized.
This comment has been minimized.
lintool
May 29, 2020
Member
Apologies in advance if this has been hashed out already, but have we agreed on a naming convention for these? Naming seems inconsistent at present...
This comment has been minimized.
This comment has been minimized.
|
Ran through the two provided notebooks with CPP sample data - thanks for those @ruebot. All works perfectly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedMay 29, 2020
GitHub issue(s): #467
What does this Pull Request do?
Move Python UDF methods out of their own class.
How should this be tested?