Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 Python app method names. #477

Merged
merged 2 commits into from May 29, 2020
Merged

PEP8 Python app method names. #477

merged 2 commits into from May 29, 2020

Conversation

@ruebot
Copy link
Member

ruebot commented May 29, 2020

- Resolve 468
ruebot added a commit to archivesunleashed/aut-docs that referenced this pull request May 29, 2020
ruebot added a commit to archivesunleashed/notebooks that referenced this pull request May 29, 2020
@ruebot ruebot requested review from ianmilligan1 and lintool May 29, 2020
src/main/python/aut/app.py Outdated Show resolved Hide resolved
src/main/python/aut/app.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #477 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files          44       44           
  Lines        1297     1297           
  Branches      250      250           
=======================================
  Hits         1088     1088           
  Misses         80       80           
  Partials      129      129           
Copy link
Member

ianmilligan1 left a comment

Looks good to me; I'll defer to @ruebot and @lintool whether they should be capitalized file extensions or not in WriteGexf and WriteGraphml (a quick read of PEP8 doesn't seem to give a definitive answer but you would both be more familiar with this).

ruebot added a commit to archivesunleashed/notebooks that referenced this pull request May 29, 2020
@ianmilligan1 ianmilligan1 merged commit 8037745 into master May 29, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 76c8247...37cbb8e
Details
codecov/project 83.88% (+0.00%) compared to 76c8247
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 deleted the issue-468 branch May 29, 2020
ianmilligan1 pushed a commit to archivesunleashed/aut-docs that referenced this pull request May 29, 2020
#67)

* Documentation update for archivesunleashed/aut#477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.