Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove DetectMimeTypeTika and related test. #331
+0
−66
Conversation
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Sure thing! Am in online course filming all morning but should be able to do this in the afternoon. |
This comment has been minimized.
This comment has been minimized.
|
Cool. No rush on this one. |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jul 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 74.97% 74.79% -0.18%
==========================================
Files 39 38 -1
Lines 1123 1115 -8
Branches 197 196 -1
==========================================
- Hits 842 834 -8
Misses 215 215
Partials 66 66Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Jul 25, 2019
|
Finished early! Ran through the suite of scripts in our documentation and everything worked on the example data file. So it's good to go on my end. |
This comment has been minimized.
This comment has been minimized.
ruebot
closed this
Jul 31, 2019
ruebot
deleted the
issue-330
branch
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedJul 25, 2019
GitHub issue(s): #330
What does this Pull Request do?
Remove DetectMimeTypeTika and related test. See #330 for background and any discussion.
How should this be tested?
@ianmilligan1 would you mind putting this PR through a barrage of😄
auttests? Might as well take advantage of your offer, and it'll give us more data for discussion on the issue