Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSetup for Serializable APIs on DataFrames #389
Merged
+86
−3
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Dec 16, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 76.87% 77.03% +0.15%
==========================================
Files 40 40
Lines 1466 1476 +10
Branches 274 274
==========================================
+ Hits 1127 1137 +10
Misses 217 217
Partials 122 122 |
This comment has been minimized.
This comment has been minimized.
@SinghGursimran got tests? |
This comment has been minimized.
This comment has been minimized.
oh! sorry forgot about that. I will add it now. |
This comment has been minimized.
This comment has been minimized.
Looks good!
|
This comment has been minimized.
This comment has been minimized.
Once @ianmilligan1 merges #388, I'll get this merged. Should be here in a bit, or later this afternoon. |
This comment has been minimized.
This comment has been minimized.
I think we're good on docs for this, since we already have
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SinghGursimran commentedDec 16, 2019
Setup for Serializable APIs on DataFrames
#223
For Testing:
Since it is the migration of RDD's functionality to DF, final answer should be the same as given by the following transformation on RDD.