Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ExtractPopularImages, WriteGEXF, and WriteGraphML to Python. #466
Conversation
codecov
bot
commented
May 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 49 49
Lines 1442 1442
Branches 279 279
=======================================
Hits 1094 1094
Misses 218 218
Partials 130 130 |
|
Here's the documentation update PR for when the time comes. |
|
Last item here is Extract Entities. We only have an RDD implementation of that. I'd argue that NER is something down the chain folks can do with the derivatives, and we don't need to implement it in the Scala DataFrame or Python side. ...which means, we could go as far as completely removing all the NER functionality. Though, not 100% wedded to that idea. |
|
Once we merge, I'm move those two notebooks over to the notebooks repo. |
|
This all works perfectly - tested all three and the results are nice (loaded up in Gephi well too). |
ruebot commentedMay 25, 2020
•
edited
GitHub issue(s): #409
What does this Pull Request do?
Add ExtractPopularImages, WriteGEXF, and WriteGraphML to Python.
How should this be tested?
[nruest@bomba:/tmp]$ wc -l scala-example.gexf ~/Projects/au/sample-data/notebook-testing/test.gexf 29186 scala-example.gexf 29186 /home/nruest/Projects/au/sample-data/notebook-testing/test.gexf 58372 total[nruest@bomba:/tmp]$ wc -l scala-example.graphml ~/Projects/au/sample-data/notebook-testing/test.graphml 33911 scala-example.graphml 33911 /home/nruest/Projects/au/sample-data/notebook-testing/test.graphml 67822 total