Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Python implementation of SaveBytes. #482
Merged
Conversation
ruebot
added a commit
to archivesunleashed/notebooks
that referenced
this pull request
Jun 16, 2020
codecov
bot
commented
Jun 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 43 43
Lines 1245 1245
Branches 239 239
=======================================
Hits 1042 1042
Misses 80 80
Partials 123 123 |
ruebot
added a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Jun 16, 2020
|
Documentation PR: archivesunleashed/aut-docs#78 |
|
Tested and works really well! First image I pulled out: |
ianmilligan1
pushed a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Jun 17, 2020
#78) * Documentation update for archivesunleashed/aut#482 * Update typos in 0.80.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedJun 16, 2020
GitHub issue(s): #478
What does this Pull Request do?
Add Python implementation of SaveBytes.
How should this be tested?
Here's an example notebook.
Additional Notes:
This isn't an ideal solution. From my research, I don't see an easy way to extend the DataFrame class on the Python side, since it's basically a wrapper around the Scala implementation. I also can't for the life of my implement our Scala
saveToDiskimplementation on the Python side. I can't figure out how to wire up the implicit class we have plus the function. But, the positive side of it is that it does mimicWriteGraphMLandWriteGEXFimplementations on the Python and Scala side.I'll get a documentation PR in once I'm unblocked on archivesunleashed/aut-docs#76