Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocumentation updates for https://github.com/archivesunleashed/aut/pu… #83
+10
−6
Conversation
docs/dependencies.md
Outdated
| `export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64` or on macOS it might be | ||
| `export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home`. | ||
| `export JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64` or on macOS it might be | ||
| `export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.11.0_74.jdk/Contents/Home`. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Jun 18, 2020
Member
On mine it's
export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-11.0.5.jdk/Contents/Home
For Java 8 it was similar to what you had before, I think the naming convention may have changed.
|
@ianmilligan1 @SamFritz I think this is all that needs to be updated in the documentation. Can you double-check and make sure? |
|
Looks good to me; would just consider making the change to the |
And yes, just did a search and a walk through, I think you've updated everywhere that needs to be updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedJun 18, 2020
…ll/375