Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate log4j configuration to resolve #433. #434
Merged
+446
−213
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 77.70% 77.99% +0.28%
==========================================
Files 41 43 +2
Lines 1534 1554 +20
Branches 282 286 +4
==========================================
+ Hits 1192 1212 +20
Misses 217 217
Partials 125 125 |
|
Works like a charm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedApr 7, 2020
GitHub issue(s): #433
What does this Pull Request do?
Update
log4jconfiguration to resolve #433.How should this be tested?
On master:
bin/spark-submit --master local[8] --class io.archivesunleashed.app.CommandLineAppRunner /home/nruest/Projects/au/aut-releases/aut-0.50.0-fatjar.jar --extractor DomainFrequencyExtractor --input /home/nruest/Projects/au/sample-data/geocities/* --output /home/nruest/Projects/au/sample-data/app-output/DomainFrequencyExtractorThat should quietly fail, and do nothing. You might see the
WARNoutlined in #433.Using the build from this branch, the same command should work fine.
Additional Notes:
I created this branch off of #432 so, this should be squashed and merged that after PR is merged.