Skip to content

/ prediction

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for svyglm models and fix for #39 #41

Open
wants to merge 6 commits into
base: master
from
Open

Better handling for svyglm models and fix for #39 #41

wants to merge 6 commits into from
+96 −36

Conversation

@tzoltak
Copy link

tzoltak commented Aug 7, 2019

  • [v] if suggesting code changes or improvements, open an issue first
  • [v] for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • [v] for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • [v] add code or new test files to /tests for any new functionality or bug fix
  • [v] make sure R CMD check runs without error before submitting the PR

This pull requests deals with #39 and #40 .
tzoltak added 6 commits Jun 17, 2019
tzoltak
find_data correctly supports svyglm models
1432cb6
tzoltak
find_data() methods for survey design objects
bfb91e6
tzoltak
prediction.svyglm() deals with (new) data that conatins NAs
8bcb008
tzoltak
build_datalist() preserves levels of factors that are mentioned in `at`
e8b27af
tzoltak
prediction.svyglm() deals with `data` being survey design object
7838c5e
tzoltak
test for updates in prediction.svyglm
Loading status checks…
82b86ad
@leeper
Copy link
Owner

leeper commented Jun 20, 2020

Thanks or this and sorry for long delay in reviewing. Looks good to me. Can you rebase and resubmit (there are some merge conflicts)? If not, I'll try to get to it.
@leeper leeper added the enhancement label Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tzoltak @leeper
You can’t perform that action at this time.