Skip to content

/ prediction

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ridge::linearRidge predictions #45

Merged
merged 11 commits into from Jun 20, 2020
Merged

Add support for ridge::linearRidge predictions #45

merged 11 commits into from Jun 20, 2020
+132 −11

Conversation

@dfrankow
Copy link
Contributor

dfrankow commented Mar 18, 2020

I went through every item in "Please ensure the following before submitting a PR".
dfrankow added 5 commits Mar 18, 2020
@dfrankow
.Rbuildignore
095788b
@dfrankow
Add prediction.ridgeLinear without se.fit
4be7a28
@dfrankow
Fix NAMESPACE bug with devtools::document
7b8f41a
@dfrankow
Add prediction.linearRidge
29b5ae7
@dfrankow
Add issue#
Loading status checks…
05cb861
@dfrankow
Copy link
Contributor Author

dfrankow commented Mar 18, 2020

NOTE: factors working relies on ridge releasing 2.5. See SteffenMoritz/ridge#3.
@dfrankow
Remove 'ridgeLinear' (a typo), it's 'linearRidge
Loading status checks…
7b28e87
@dfrankow
Copy link
Contributor Author

dfrankow commented Mar 18, 2020

My mistake.

ridge 2.5 (as yet unreleased) is needed for vcov support, not for factor support.
@dfrankow dfrankow mentioned this pull request Mar 18, 2020
Closed
dfrankow added 4 commits Mar 19, 2020
@dfrankow
Test find_data for linearRidge
Loading status checks…
a66f076
@dfrankow
Implement find_data.ridgeLinear
Loading status checks…
7eae5e0
@dfrankow
export find_data.ridgeLinear
Loading status checks…
4f23ec3
@dfrankow
fix test
Loading status checks…
de296f2
@dfrankow
Copy link
Contributor Author

dfrankow commented Mar 19, 2020

Note also that calculate_se is not implemented. But, I am looking into implementing it.
@dfrankow
remove unneeded paste0
Loading status checks…
bfb66f8
@leeper leeper merged commit 78516f2 into leeper:master Jun 20, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@leeper
Copy link
Owner

leeper commented Jun 20, 2020

thanks for this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dfrankow @leeper
You can’t perform that action at this time.