Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbugfix prediction_glm.R newdata argument #33
+20
−3
Conversation
vincentarelbundock
referenced this pull request
Mar 10, 2019
Open
`data` argument breaks with `glm` but works with `lm` #32
This comment has been minimized.
This comment has been minimized.
@leeper When you have a second, do you think you could take a look at this one? This PR would allow me to fix Travis failures and finish up work downstream in I only modified 2 lines of actual code and added a test, so it shouldn't be very difficult to review. I also added my name as contributor, but this is so minor that I would be happy to remove it. Travis works in 5 of the 6 cases; the only case where it fails relates to package installation in an old R release, so it has nothing to do with this commit. |
This comment has been minimized.
This comment has been minimized.
Looks great. Thanks! |
leeper
merged commit 96071dd
into
leeper:master
Apr 6, 2019
This comment has been minimized.
This comment has been minimized.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vincentarelbundock commentedMar 10, 2019
•
edited
This is a minor bugfix (with a new test) for: #32
I'm not sure how your version numbers work, so I just added a new entry to NEWS.
This problem was caused by calling
predict(data = )
instead ofpredict(newdata =
in a couple places inprediction_glm.R
.Please ensure the following before submitting a PR:
/R
not/man
and rundevtools::document()
to update documentation/tests
for any new functionality or bug fixR CMD check
runs without error before submitting the PR