Prevent data.table errors in check_values() #34

danschrage · 2019-04-02T06:59:29Z

check_values() relies on selecting variables using a vector of strings corresponding to names. If data is a data.table, this requires the option "with=FALSE". If we instead coerce data to a data.frame at the start of the function, we avoid this error.

This is a bugfix for issue #35.

Please ensure the following before submitting a PR:

if suggesting code changes or improvements, open an issue first
for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
add code or new test files to /tests for any new functionality or bug fix
make sure R CMD check runs without error before submitting the PR


        Prevent data.table errors in check_values()

check_values() relies on selecting variables using a vector of strings corresponding to names. If data is a data.table, this requires the option "with=FALSE". If we instead coerce data to a data.frame at the start of the function, we avoid this error.

leeper · 2019-12-24T16:43:28Z

Thanks. Looks like the best fix for this is to be more data.table aware rather than doing a class coercion. I'm sending a patch.


        make build_datalist() work with data.table (closes #34, closes #35)

danschrage mentioned this pull request Apr 2, 2019

"at" functionality breaks when model data is a data.table #35

Closed

leeper closed this Dec 24, 2019

leeper added a commit that referenced this pull request Dec 24, 2019

make build_datalist() work with data.table (closes #34, closes #35)

846b1bf

Please note that GitHub no longer supports your web browser.

leeper/prediction

Prevent data.table errors in check_values() #34

Prevent data.table errors in check_values() #34

danschrage commented Apr 2, 2019 •

edited

This comment has been minimized.

leeper commented Dec 24, 2019

Please note that GitHub no longer supports your web browser.

leeper/prediction

Join GitHub today

Prevent data.table errors in check_values() #34

Prevent data.table errors in check_values() #34

Conversation

danschrage commented Apr 2, 2019 • edited

This comment has been minimized.

leeper commented Dec 24, 2019

danschrage commented Apr 2, 2019 •

edited