/estimatr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for cplot.default method from margins #111

Closed
lukesonnet opened this Issue Jan 26, 2018 · 5 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@lukesonnet @leeper @macartan @graemeblair
@lukesonnet
Member

lukesonnet commented Jan 26, 2018

Once on CRAN, should we ask @leeper to change cplot.lm to cplot.default as cplot.lm works with "lm_robust" objects but users have to call it like so margins:::cplot.lm()?

Seems like most model objects have what cplot.lm wants. We could also consider writing our own wrapper.

@lukesonnet lukesonnet added the question label Jan 26, 2018

@leeper

This comment has been minimized.

Show comment
Hide comment
@leeper

leeper Jan 26, 2018

I can probably do this. Can you open an issue about it?

leeper commented Jan 26, 2018

I can probably do this. Can you open an issue about it?
@lukesonnet

This comment has been minimized.

Show comment
Hide comment
@lukesonnet

lukesonnet Jan 26, 2018

Member

Sure, did so leeper/margins#84!
Member

lukesonnet commented Jan 26, 2018 •
edited
Edited 1 time
  • @lukesonnet lukesonnet edited Jan 26, 2018 (most recent)

Sure, did so leeper/margins#84!
@leeper

This comment has been minimized.

Show comment
Hide comment
@leeper

leeper Aug 1, 2018

This is now implemented in margins.

leeper commented Aug 1, 2018

This is now implemented in margins.
@macartan

This comment has been minimized.

Show comment
Hide comment
@macartan

macartan Aug 1, 2018

macartan commented Aug 1, 2018

@graemeblair

This comment has been minimized.

Show comment
Hide comment
@graemeblair

graemeblair Aug 2, 2018

Member

Closing this. Thanks so much @leeper - really happy about this full integration!
Member

graemeblair commented Aug 2, 2018

Closing this. Thanks so much @leeper - really happy about this full integration!

@graemeblair graemeblair closed this Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment