Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix a bug in `margins()` with `glmerMod` objects (#129) #43
+37
−22
Conversation
vincentarelbundock
force-pushed the
vincentarelbundock:master
branch
from
Mar 6, 2020
aa26691
to
5e6806b
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vincentarelbundock commentedMar 6, 2020
Please ensure the following before submitting a PR:
R CMD check
runs without error before submitting the PRIn combination with my concurrent PR at leeper/margins this fixes Issue #129 of margins.
Here, I am simply improving
find_data.merMod
. I have written no new code for this. I just copied over thefind_data.default
method, and modified themodel[['class']]
bymodel@class
, becauseglmerMod
is a S4.