Skip to content

/ margins

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #129: glmer bug (requires merge of PR in prediction repo) #138

Merged
merged 2 commits into from Jun 20, 2020
Merged

issue #129: glmer bug (requires merge of PR in prediction repo) #138

merged 2 commits into from Jun 20, 2020

Conversation

@vincentarelbundock
Copy link
Contributor

vincentarelbundock commented Mar 6, 2020

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • make sure R CMD check runs without error before submitting the PR

In combination with my concurrent PR at leeper/prediction this fixes Issue #129.

Here, I am simply adding another fallback option when variable classes cannot be extracted easily from term(model)[['dataClasses']]. I use terms(model.frame(model)) to get the info we need.
@vincentarelbundock
issue #129: glmer bug (requires merge of PR in prediction repo)
Loading status checks…
a994c13
@vincentarelbundock
Merge branch 'master' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d67e7d7
@codecov-io
Copy link

codecov-io commented Mar 6, 2020

Codecov Report

Merging #138 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   77.96%   77.91%   -0.05%     
==========================================
  Files          39       39              
  Lines        1207     1209       +2     
==========================================
+ Hits          941      942       +1     
- Misses        266      267       +1
Impacted Files Coverage Δ
R/find_terms_in_model.R 95% <66.66%> (-2.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9426bf7...d67e7d7. Read the comment docs.
@vincentarelbundock
Copy link
Contributor Author

vincentarelbundock commented Mar 6, 2020

leeper/prediction#43
@leeper leeper merged commit 624acdb into leeper:master Jun 20, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@vincentarelbundock @codecov-io @leeper
You can’t perform that action at this time.