Skip to content

/auk-notebooks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting out for File outputs is not intuitive #44

Closed
greebie opened this Issue Mar 21, 2019 · 4 comments

Comments

Assignees

@ianmilligan1 ianmilligan1

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@greebie @ruebot @ianmilligan1
@greebie
Copy link
Collaborator

commented Mar 21, 2019 •
edited

Having comments for people to remove so they can save files is not the most intuitive approach for some users. Is there a better way to do this?

ianmilligan1 added a commit that referenced this issue Apr 23, 2019

@ianmilligan1
In-progress work on #44
1dbc46d

@ianmilligan1 ianmilligan1 self-assigned this Apr 23, 2019

@ianmilligan1 ianmilligan1 referenced this issue Apr 23, 2019

Closed

write_output doesn't work #54

@greebie

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Apr 24, 2019

Issue seems to be a variable switch from filename to stdout in au_notebook. I will submit a PR there once I'm sure it works.
@greebie

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Apr 24, 2019

Once completed there will be a small PR here as well to switch to nb.write_output().
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 24, 2019

@greebie do you mean to be commenting here, or on #54 ?
@greebie

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Apr 24, 2019

Too many windows open in FF. Yes #54.

ianmilligan1 added a commit that referenced this issue Apr 25, 2019

@ianmilligan1
Reworking file outputs, resolves #44
Loading status checks…
446d633

@ianmilligan1 ianmilligan1 referenced this issue Apr 25, 2019

Merged

Reworks file outputs, resolves #44 #56

@ruebot ruebot closed this in ab76abe Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.