Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case, and actually resolve #16. #21

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@ruebot
Copy link
Member

ruebot commented Mar 5, 2019

@ruebot ruebot requested review from greebie and ianmilligan1 Mar 5, 2019

@ruebot ruebot referenced this pull request Mar 5, 2019

Open

Example collection #13

@greebie

greebie approved these changes Mar 5, 2019

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 5, 2019

This one was my bad. I was sure I had a var there, but then I assumed I deleted it for a reason. I think the var is a better idea, just in case someone ends up creating additional scripts and wants to change all them at once.

@ianmilligan1 ianmilligan1 merged commit 9af6509 into master Mar 5, 2019

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ianmilligan1 ianmilligan1 deleted the issue-16-b branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.