Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating README content - Issue 23 #34
+25
−10
Conversation
SamFritz
added
the
enhancement
label
Mar 7, 2019
SamFritz
self-assigned this
Mar 7, 2019
SamFritz
requested review from
ruebot
and
ianmilligan1
Mar 7, 2019
ruebot
requested changes
Mar 7, 2019
One small change, and a question. |
README.md
Outdated
@@ -38,6 +38,10 @@ python -m nltk.downloader punkt vader_lexicon stopwords | |||
jupyter notebook | |||
``` | |||
|
|||
### Docker | |||
|
|||
Docker is a container-based virtual machine system that bundles dependencies together, this means you can build the docker image and it will work out of the box. To run the Jupyter Notebook via Docker, there are two options, Docker Hub and Docker Locally. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
README.md
Outdated
|
||
There are several types of visualizations that you can produce in the Jupyter Notebook. A total of 14 outputs can be generated. | ||
|
||
* *Domain Analysis* - provides information about what has been crawled (e.g. which domains) and how often. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianmilligan1
requested changes
Mar 7, 2019
Some minor tweaks but this looks great! |
README.md
Outdated
|
||
There are several types of visualizations that you can produce in the Jupyter Notebook. A total of 14 outputs can be generated. | ||
|
||
* *Domain Analysis* - provides information about what has been crawled (e.g. which domains) and how often. |
This comment has been minimized.
This comment has been minimized.
README.md
Outdated
|
||
There are several types of visualizations that you can produce in the Jupyter Notebook. A total of 14 outputs can be generated. | ||
|
||
* *Domain Analysis* - provides information about what has been crawled (e.g. which domains) and how often. |
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Mar 7, 2019
Member
Maybe change the - to a :
in the list
i.e.
- Domain Analysis: Provides information about what has been crawled (e.g. which domains) and how often.
and same for the other items in this bullet-pointed list.
README.md
Outdated
|
||
This repository also uses the [Jupyter Docker Stacks](https://jupyter-docker-stacks.readthedocs.io/en/latest/index.html), which provide [a lot of helpful options to take advantage of](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#docker-options). | ||
This repository also uses the [Jupyter Docker Stacks](https://jupyter-docker-stacks.readthedocs.io/en/latest/index.html), which provide some helpful options for [customizing](https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#docker-options) the container environment. |
This comment has been minimized.
This comment has been minimized.
ruebot
approved these changes
Mar 7, 2019
ianmilligan1
approved these changes
Mar 7, 2019
ianmilligan1
merged commit 5becb28
into
master
Mar 7, 2019
1 check passed
ci/dockercloud
Your tests passed in Docker Cloud
Details
ianmilligan1
deleted the
issue-23
branch
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SamFritz commentedMar 7, 2019
This pull request addresses #23 and comes on the heels of additions/modifications made by @ruebot in issue #32
This pull requests does the following:
Thanks for the second and third set of eyes!!