Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd comment on try/catch, and remove explicit exception; #37. #41
Conversation
ruebot
requested review from
greebie
and
ianmilligan1
Mar 14, 2019
greebie
approved these changes
Mar 14, 2019
|
Yes. Probably best to do that for any error on the network. |
| @@ -928,6 +928,7 @@ | |||
| "source": [ | |||
| "# Degree distribution of domains.\n", | |||
| "\n", | |||
| "# We wrap a few cells below in try/catch statements in-case the Cloud doesn't produce graph files.\n", | |||
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Mar 14, 2019
Member
in-case to in case
Otherwise comment + explicit exception removal look perfect to me!
ianmilligan1
approved these changes
Mar 14, 2019
ianmilligan1
merged commit 10e9177
into
master
Mar 14, 2019
ianmilligan1
deleted the
37-follow-up
branch
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedMar 14, 2019
A couple items I discussed on Wednesday call.
Let me know if y'all want to change anything.