Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTests #336
+101
−16
Conversation
jrwiebe
and others
added some commits
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jul 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 75% 75.97% +0.97%
==========================================
Files 39 39
Lines 1124 1124
Branches 197 197
==========================================
+ Hits 843 854 +11
+ Misses 215 205 -10
+ Partials 66 65 -1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Cool. Looks like we resolve #265 and I'd mark #263 as closed too since it'll be up around 99% covered. @ianmilligan1 if you're good with this, I'll write a commit message, and highlight @jrwiebe's work on this in the message. |
ianmilligan1
approved these changes
Jul 31, 2019
Looks good to me, @ruebot. If you provide commit message I can squash+merge. |
This comment has been minimized.
This comment has been minimized.
|
ianmilligan1
merged commit 605afcc
into
master
Jul 31, 2019
ianmilligan1
deleted the
tests
branch
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedJul 31, 2019
Checking this branch against CodeCov to see what happens before I consider deleting it.